From 191f62688079d644fe7ac471b2725e79e4d87f48 Mon Sep 17 00:00:00 2001 From: James Young <18669334+noroadsleft@users.noreply.github.com> Date: Sun, 21 Apr 2024 17:54:11 -0700 Subject: [PATCH] Data-Driven Keyboard Conversions: K, Part 3 (#23566) --- .../keebformom/{info.json => keyboard.json} | 12 +++++++++++- keyboards/keebformom/rules.mk | 15 --------------- .../bdn9/rev1/{info.json => keyboard.json} | 10 ++++++++++ keyboards/keebio/bdn9/rev1/rules.mk | 13 ------------- .../bdn9/rev2/{info.json => keyboard.json} | 9 +++++++++ keyboards/keebio/bdn9/rev2/rules.mk | 15 --------------- .../dsp40/rev1/{info.json => keyboard.json} | 9 +++++++++ keyboards/keebio/dsp40/rev1/rules.mk | 13 ------------- keyboards/keebio/foldkb/rev1/info.json | 11 +++++++++++ keyboards/keebio/foldkb/rev1/rules.mk | 3 --- keyboards/keebio/foldkb/rules.mk | 14 -------------- .../iris/rev2/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/iris/rev2/rules.mk | 14 -------------- .../iris/rev3/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/iris/rev3/rules.mk | 15 --------------- .../iris/rev4/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/iris/rev4/rules.mk | 16 ---------------- .../iris/rev6/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/iris/rev6/rules.mk | 16 ---------------- .../iris/rev7/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/iris/rev7/rules.mk | 16 ---------------- .../kbo5000/rev1/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/kbo5000/rev1/rules.mk | 3 --- keyboards/keebio/kbo5000/rules.mk | 14 -------------- .../levinson/rev1/{info.json => keyboard.json} | 6 ++++++ keyboards/keebio/levinson/rev1/rules.mk | 1 - .../levinson/rev2/{info.json => keyboard.json} | 6 ++++++ keyboards/keebio/levinson/rev2/rules.mk | 1 - keyboards/keebio/levinson/rev3/info.json | 6 ++++++ keyboards/keebio/levinson/rev3/rules.mk | 2 -- keyboards/keebio/levinson/rules.mk | 13 ------------- .../quefrency/rev1/{info.json => keyboard.json} | 9 +++++++++ keyboards/keebio/quefrency/rev1/rules.mk | 1 - .../quefrency/rev2/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/quefrency/rev2/rules.mk | 3 --- .../quefrency/rev3/{info.json => keyboard.json} | 11 +++++++++++ keyboards/keebio/quefrency/rev3/rules.mk | 3 --- .../quefrency/rev4/{info.json => keyboard.json} | 10 ++++++++++ keyboards/keebio/quefrency/rev4/rules.mk | 3 --- .../quefrency/rev5/{info.json => keyboard.json} | 10 ++++++++++ keyboards/keebio/quefrency/rev5/rules.mk | 3 --- keyboards/keebio/quefrency/rules.mk | 11 ----------- .../rorschach/rev1/{info.json => keyboard.json} | 8 ++++++++ keyboards/keebio/rorschach/rev1/rules.mk | 1 - keyboards/keebio/rorschach/rules.mk | 13 ------------- .../viterbi/rev1/{info.json => keyboard.json} | 5 +++++ keyboards/keebio/viterbi/rev1/rules.mk | 1 - .../viterbi/rev2/{info.json => keyboard.json} | 9 +++++++++ keyboards/keebio/viterbi/rev2/rules.mk | 3 --- keyboards/keebio/viterbi/rules.mk | 13 ------------- keyboards/keebio/wavelet/info.json | 8 ++++++++ keyboards/keebio/wavelet/rules.mk | 13 ------------- keyboards/keebwerk/mega/ansi/info.json | 6 ++++++ keyboards/keebwerk/mega/ansi/rules.mk | 13 ------------- keyboards/keebwerk/nano_slider/info.json | 11 +++++++++++ keyboards/keebwerk/nano_slider/rules.mk | 15 --------------- 56 files changed, 232 insertions(+), 281 deletions(-) rename keyboards/keebformom/{info.json => keyboard.json} (92%) delete mode 100644 keyboards/keebformom/rules.mk rename keyboards/keebio/bdn9/rev1/{info.json => keyboard.json} (82%) delete mode 100644 keyboards/keebio/bdn9/rev1/rules.mk rename keyboards/keebio/bdn9/rev2/{info.json => keyboard.json} (93%) delete mode 100644 keyboards/keebio/bdn9/rev2/rules.mk rename keyboards/keebio/dsp40/rev1/{info.json => keyboard.json} (96%) delete mode 100644 keyboards/keebio/dsp40/rev1/rules.mk rename keyboards/keebio/iris/rev2/{info.json => keyboard.json} (94%) delete mode 100644 keyboards/keebio/iris/rev2/rules.mk rename keyboards/keebio/iris/rev3/{info.json => keyboard.json} (95%) delete mode 100644 keyboards/keebio/iris/rev3/rules.mk rename keyboards/keebio/iris/rev4/{info.json => keyboard.json} (95%) delete mode 100644 keyboards/keebio/iris/rev4/rules.mk rename keyboards/keebio/iris/rev6/{info.json => keyboard.json} (96%) delete mode 100644 keyboards/keebio/iris/rev6/rules.mk rename keyboards/keebio/iris/rev7/{info.json => keyboard.json} (96%) delete mode 100644 keyboards/keebio/iris/rev7/rules.mk rename keyboards/keebio/kbo5000/rev1/{info.json => keyboard.json} (98%) delete mode 100644 keyboards/keebio/kbo5000/rev1/rules.mk rename keyboards/keebio/levinson/rev1/{info.json => keyboard.json} (96%) delete mode 100644 keyboards/keebio/levinson/rev1/rules.mk rename keyboards/keebio/levinson/rev2/{info.json => keyboard.json} (96%) delete mode 100644 keyboards/keebio/levinson/rev2/rules.mk rename keyboards/keebio/quefrency/rev1/{info.json => keyboard.json} (99%) delete mode 100644 keyboards/keebio/quefrency/rev1/rules.mk rename keyboards/keebio/quefrency/rev2/{info.json => keyboard.json} (99%) delete mode 100644 keyboards/keebio/quefrency/rev2/rules.mk rename keyboards/keebio/quefrency/rev3/{info.json => keyboard.json} (99%) delete mode 100644 keyboards/keebio/quefrency/rev3/rules.mk rename keyboards/keebio/quefrency/rev4/{info.json => keyboard.json} (99%) delete mode 100644 keyboards/keebio/quefrency/rev4/rules.mk rename keyboards/keebio/quefrency/rev5/{info.json => keyboard.json} (99%) delete mode 100644 keyboards/keebio/quefrency/rev5/rules.mk rename keyboards/keebio/rorschach/rev1/{info.json => keyboard.json} (95%) delete mode 100644 keyboards/keebio/rorschach/rev1/rules.mk rename keyboards/keebio/viterbi/rev1/{info.json => keyboard.json} (97%) delete mode 100644 keyboards/keebio/viterbi/rev1/rules.mk rename keyboards/keebio/viterbi/rev2/{info.json => keyboard.json} (96%) delete mode 100644 keyboards/keebio/viterbi/rev2/rules.mk diff --git a/keyboards/keebformom/info.json b/keyboards/keebformom/keyboard.json similarity index 92% rename from keyboards/keebformom/info.json rename to keyboards/keebformom/keyboard.json index 8262b4bf4e..b1ffee0f3d 100644 --- a/keyboards/keebformom/info.json +++ b/keyboards/keebformom/keyboard.json @@ -6,7 +6,8 @@ "usb": { "vid": "0x458F", "pid": "0x14E2", - "device_version": "1.0.0" + "device_version": "1.0.0", + "no_startup_check": true }, "ws2812": { "pin": "F4" @@ -30,6 +31,15 @@ "diode_direction": "COL2ROW", "processor": "atmega32u4", "bootloader": "caterina", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true + }, + "build": { + "lto": true + }, + "community_layouts": ["ortho_4x10"], "layouts": { "LAYOUT_ortho_4x10": { "layout": [ diff --git a/keyboards/keebformom/rules.mk b/keyboards/keebformom/rules.mk deleted file mode 100644 index 50c95c8bbd..0000000000 --- a/keyboards/keebformom/rules.mk +++ /dev/null @@ -1,15 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output -LTO_ENABLE = yes -NO_USB_STARTUP_CHECK = yes -LAYOUTS = ortho_4x10 diff --git a/keyboards/keebio/bdn9/rev1/info.json b/keyboards/keebio/bdn9/rev1/keyboard.json similarity index 82% rename from keyboards/keebio/bdn9/rev1/info.json rename to keyboards/keebio/bdn9/rev1/keyboard.json index 0167052f6d..9ab64e25d6 100644 --- a/keyboards/keebio/bdn9/rev1/info.json +++ b/keyboards/keebio/bdn9/rev1/keyboard.json @@ -38,6 +38,16 @@ }, "processor": "atmega32u4", "bootloader": "caterina", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "console": true, + "command": true, + "backlight": true, + "rgblight": true, + "encoder": true + }, "matrix_pins": { "direct": [ ["D2", "D4", "F4"], diff --git a/keyboards/keebio/bdn9/rev1/rules.mk b/keyboards/keebio/bdn9/rev1/rules.mk deleted file mode 100644 index b0fc1d94e5..0000000000 --- a/keyboards/keebio/bdn9/rev1/rules.mk +++ /dev/null @@ -1,13 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = yes # Console for debug -COMMAND_ENABLE = yes # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/bdn9/rev2/info.json b/keyboards/keebio/bdn9/rev2/keyboard.json similarity index 93% rename from keyboards/keebio/bdn9/rev2/info.json rename to keyboards/keebio/bdn9/rev2/keyboard.json index 74d6dac85b..174c5c826a 100644 --- a/keyboards/keebio/bdn9/rev2/info.json +++ b/keyboards/keebio/bdn9/rev2/keyboard.json @@ -85,6 +85,15 @@ }, "processor": "STM32F072", "bootloader": "stm32-dfu", + "features": { + "bootmagic": true, + "mousekey": true, + "extrakey": true, + "console": true, + "command": true, + "encoder": true, + "rgb_matrix": true + }, "matrix_pins": { "direct": [ ["B12", "B5", "B6"], diff --git a/keyboards/keebio/bdn9/rev2/rules.mk b/keyboards/keebio/bdn9/rev2/rules.mk deleted file mode 100644 index e407769147..0000000000 --- a/keyboards/keebio/bdn9/rev2/rules.mk +++ /dev/null @@ -1,15 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = yes # Console for debug -COMMAND_ENABLE = yes # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output -ENCODER_ENABLE = yes -RGB_MATRIX_ENABLE = yes - diff --git a/keyboards/keebio/dsp40/rev1/info.json b/keyboards/keebio/dsp40/rev1/keyboard.json similarity index 96% rename from keyboards/keebio/dsp40/rev1/info.json rename to keyboards/keebio/dsp40/rev1/keyboard.json index cc8fa692cd..2011a23b7e 100644 --- a/keyboards/keebio/dsp40/rev1/info.json +++ b/keyboards/keebio/dsp40/rev1/keyboard.json @@ -48,6 +48,15 @@ }, "processor": "STM32F072", "bootloader": "stm32-dfu", + "features": { + "bootmagic": true, + "mousekey": true, + "extrakey": true, + "console": true, + "command": true, + "backlight": true, + "encoder": true + }, "layout_aliases": { "LAYOUT_40_staggered": "LAYOUT" }, diff --git a/keyboards/keebio/dsp40/rev1/rules.mk b/keyboards/keebio/dsp40/rev1/rules.mk deleted file mode 100644 index 8c70082a37..0000000000 --- a/keyboards/keebio/dsp40/rev1/rules.mk +++ /dev/null @@ -1,13 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = yes # Console for debug -COMMAND_ENABLE = yes # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/foldkb/rev1/info.json b/keyboards/keebio/foldkb/rev1/info.json index cc3fe50636..891e2ce74b 100644 --- a/keyboards/keebio/foldkb/rev1/info.json +++ b/keyboards/keebio/foldkb/rev1/info.json @@ -47,6 +47,17 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": true, + "mousekey": false, + "extrakey": true, + "backlight": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/foldkb/rev1/rules.mk b/keyboards/keebio/foldkb/rev1/rules.mk index 32e7881599..e69de29bb2 100644 --- a/keyboards/keebio/foldkb/rev1/rules.mk +++ b/keyboards/keebio/foldkb/rev1/rules.mk @@ -1,3 +0,0 @@ -BACKLIGHT_ENABLE = yes -RGBLIGHT_ENABLE = yes -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/foldkb/rules.mk b/keyboards/keebio/foldkb/rules.mk index b9c01e0aff..6a0522a902 100644 --- a/keyboards/keebio/foldkb/rules.mk +++ b/keyboards/keebio/foldkb/rules.mk @@ -1,15 +1 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output -LTO_ENABLE = yes - DEFAULT_FOLDER = keebio/foldkb/rev1 diff --git a/keyboards/keebio/iris/rev2/info.json b/keyboards/keebio/iris/rev2/keyboard.json similarity index 94% rename from keyboards/keebio/iris/rev2/info.json rename to keyboards/keebio/iris/rev2/keyboard.json index bbd6f97cf4..fafa9ba924 100644 --- a/keyboards/keebio/iris/rev2/info.json +++ b/keyboards/keebio/iris/rev2/keyboard.json @@ -38,6 +38,17 @@ }, "processor": "atmega32u4", "bootloader": "caterina", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "console": true, + "backlight": true, + "rgblight": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/iris/rev2/rules.mk b/keyboards/keebio/iris/rev2/rules.mk deleted file mode 100644 index d7e69407a2..0000000000 --- a/keyboards/keebio/iris/rev2/rules.mk +++ /dev/null @@ -1,14 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = yes # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. - -LTO_ENABLE = yes \ No newline at end of file diff --git a/keyboards/keebio/iris/rev3/info.json b/keyboards/keebio/iris/rev3/keyboard.json similarity index 95% rename from keyboards/keebio/iris/rev3/info.json rename to keyboards/keebio/iris/rev3/keyboard.json index 5014519408..8ce5ed8979 100644 --- a/keyboards/keebio/iris/rev3/info.json +++ b/keyboards/keebio/iris/rev3/keyboard.json @@ -49,6 +49,17 @@ }, "processor": "atmega32u4", "bootloader": "qmk-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "backlight": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/iris/rev3/rules.mk b/keyboards/keebio/iris/rev3/rules.mk deleted file mode 100644 index 6f0bda4dcc..0000000000 --- a/keyboards/keebio/iris/rev3/rules.mk +++ /dev/null @@ -1,15 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. - -ENCODER_ENABLE = yes -LTO_ENABLE = yes diff --git a/keyboards/keebio/iris/rev4/info.json b/keyboards/keebio/iris/rev4/keyboard.json similarity index 95% rename from keyboards/keebio/iris/rev4/info.json rename to keyboards/keebio/iris/rev4/keyboard.json index 6faf28ea44..88856e0030 100644 --- a/keyboards/keebio/iris/rev4/info.json +++ b/keyboards/keebio/iris/rev4/keyboard.json @@ -62,6 +62,17 @@ }, "processor": "atmega32u4", "bootloader": "qmk-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "backlight": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/iris/rev4/rules.mk b/keyboards/keebio/iris/rev4/rules.mk deleted file mode 100644 index 55a08a2117..0000000000 --- a/keyboards/keebio/iris/rev4/rules.mk +++ /dev/null @@ -1,16 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. - -ENCODER_ENABLE = yes - -LTO_ENABLE = yes diff --git a/keyboards/keebio/iris/rev6/info.json b/keyboards/keebio/iris/rev6/keyboard.json similarity index 96% rename from keyboards/keebio/iris/rev6/info.json rename to keyboards/keebio/iris/rev6/keyboard.json index 837bb4e0d0..7bbaabe277 100644 --- a/keyboards/keebio/iris/rev6/info.json +++ b/keyboards/keebio/iris/rev6/keyboard.json @@ -95,6 +95,17 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "console": true, + "rgb_matrix": true, + "encoder": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/iris/rev6/rules.mk b/keyboards/keebio/iris/rev6/rules.mk deleted file mode 100644 index 69d1764838..0000000000 --- a/keyboards/keebio/iris/rev6/rules.mk +++ /dev/null @@ -1,16 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = yes # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output -ENCODER_ENABLE = yes -RGB_MATRIX_ENABLE = yes - -LTO_ENABLE = yes diff --git a/keyboards/keebio/iris/rev7/info.json b/keyboards/keebio/iris/rev7/keyboard.json similarity index 96% rename from keyboards/keebio/iris/rev7/info.json rename to keyboards/keebio/iris/rev7/keyboard.json index a3f25202ce..decb81a18e 100644 --- a/keyboards/keebio/iris/rev7/info.json +++ b/keyboards/keebio/iris/rev7/keyboard.json @@ -94,6 +94,17 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "console": true, + "rgb_matrix": true, + "encoder": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/iris/rev7/rules.mk b/keyboards/keebio/iris/rev7/rules.mk deleted file mode 100644 index 69d1764838..0000000000 --- a/keyboards/keebio/iris/rev7/rules.mk +++ /dev/null @@ -1,16 +0,0 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = yes # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output -ENCODER_ENABLE = yes -RGB_MATRIX_ENABLE = yes - -LTO_ENABLE = yes diff --git a/keyboards/keebio/kbo5000/rev1/info.json b/keyboards/keebio/kbo5000/rev1/keyboard.json similarity index 98% rename from keyboards/keebio/kbo5000/rev1/info.json rename to keyboards/keebio/kbo5000/rev1/keyboard.json index 939a772348..7733f06efc 100644 --- a/keyboards/keebio/kbo5000/rev1/info.json +++ b/keyboards/keebio/kbo5000/rev1/keyboard.json @@ -61,6 +61,17 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": true, + "mousekey": false, + "extrakey": true, + "backlight": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT_ansi": { "layout": [ diff --git a/keyboards/keebio/kbo5000/rev1/rules.mk b/keyboards/keebio/kbo5000/rev1/rules.mk deleted file mode 100644 index 32e7881599..0000000000 --- a/keyboards/keebio/kbo5000/rev1/rules.mk +++ /dev/null @@ -1,3 +0,0 @@ -BACKLIGHT_ENABLE = yes -RGBLIGHT_ENABLE = yes -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/kbo5000/rules.mk b/keyboards/keebio/kbo5000/rules.mk index c6a1e8d0d1..06d2f2f412 100644 --- a/keyboards/keebio/kbo5000/rules.mk +++ b/keyboards/keebio/kbo5000/rules.mk @@ -1,15 +1 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. -LTO_ENABLE = yes - DEFAULT_FOLDER = keebio/kbo5000/rev1 diff --git a/keyboards/keebio/levinson/rev1/info.json b/keyboards/keebio/levinson/rev1/keyboard.json similarity index 96% rename from keyboards/keebio/levinson/rev1/info.json rename to keyboards/keebio/levinson/rev1/keyboard.json index 0a98e032d4..1ed976b4a9 100644 --- a/keyboards/keebio/levinson/rev1/info.json +++ b/keyboards/keebio/levinson/rev1/keyboard.json @@ -23,6 +23,12 @@ "ws2812": { "pin": "D3" }, + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true, + "backlight": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_ortho_4x12" }, diff --git a/keyboards/keebio/levinson/rev1/rules.mk b/keyboards/keebio/levinson/rev1/rules.mk deleted file mode 100644 index bd518d8f27..0000000000 --- a/keyboards/keebio/levinson/rev1/rules.mk +++ /dev/null @@ -1 +0,0 @@ -BACKLIGHT_ENABLE = yes diff --git a/keyboards/keebio/levinson/rev2/info.json b/keyboards/keebio/levinson/rev2/keyboard.json similarity index 96% rename from keyboards/keebio/levinson/rev2/info.json rename to keyboards/keebio/levinson/rev2/keyboard.json index 962f555e12..73969388d1 100644 --- a/keyboards/keebio/levinson/rev2/info.json +++ b/keyboards/keebio/levinson/rev2/keyboard.json @@ -23,6 +23,12 @@ "ws2812": { "pin": "D3" }, + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true, + "backlight": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_ortho_4x12" }, diff --git a/keyboards/keebio/levinson/rev2/rules.mk b/keyboards/keebio/levinson/rev2/rules.mk deleted file mode 100644 index bd518d8f27..0000000000 --- a/keyboards/keebio/levinson/rev2/rules.mk +++ /dev/null @@ -1 +0,0 @@ -BACKLIGHT_ENABLE = yes diff --git a/keyboards/keebio/levinson/rev3/info.json b/keyboards/keebio/levinson/rev3/info.json index cac1c3ac35..5f38fe9874 100644 --- a/keyboards/keebio/levinson/rev3/info.json +++ b/keyboards/keebio/levinson/rev3/info.json @@ -29,6 +29,12 @@ "ws2812": { "pin": "D7" }, + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true, + "backlight": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_ortho_4x12" }, diff --git a/keyboards/keebio/levinson/rev3/rules.mk b/keyboards/keebio/levinson/rev3/rules.mk index 176c9b97df..09057bea54 100644 --- a/keyboards/keebio/levinson/rev3/rules.mk +++ b/keyboards/keebio/levinson/rev3/rules.mk @@ -1,5 +1,3 @@ -BACKLIGHT_ENABLE = yes - # Disable unsupported hardware RGBLIGHT_SUPPORTED = no AUDIO_SUPPORTED = no diff --git a/keyboards/keebio/levinson/rules.mk b/keyboards/keebio/levinson/rules.mk index eab321ff01..44cdce9d12 100644 --- a/keyboards/keebio/levinson/rules.mk +++ b/keyboards/keebio/levinson/rules.mk @@ -1,14 +1 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight. - DEFAULT_FOLDER = keebio/levinson/rev2 diff --git a/keyboards/keebio/quefrency/rev1/info.json b/keyboards/keebio/quefrency/rev1/keyboard.json similarity index 99% rename from keyboards/keebio/quefrency/rev1/info.json rename to keyboards/keebio/quefrency/rev1/keyboard.json index 0bce37ad78..6bca115e66 100644 --- a/keyboards/keebio/quefrency/rev1/info.json +++ b/keyboards/keebio/quefrency/rev1/keyboard.json @@ -43,6 +43,15 @@ }, "processor": "atmega32u4", "bootloader": "caterina", + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true, + "rgblight": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/quefrency/rev1/rules.mk b/keyboards/keebio/quefrency/rev1/rules.mk deleted file mode 100644 index b771d431ad..0000000000 --- a/keyboards/keebio/quefrency/rev1/rules.mk +++ /dev/null @@ -1 +0,0 @@ -MOUSEKEY_ENABLE = yes # Mouse keys diff --git a/keyboards/keebio/quefrency/rev2/info.json b/keyboards/keebio/quefrency/rev2/keyboard.json similarity index 99% rename from keyboards/keebio/quefrency/rev2/info.json rename to keyboards/keebio/quefrency/rev2/keyboard.json index 26df29e3f0..0529fa13a6 100644 --- a/keyboards/keebio/quefrency/rev2/info.json +++ b/keyboards/keebio/quefrency/rev2/keyboard.json @@ -59,6 +59,17 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "backlight": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_60" }, diff --git a/keyboards/keebio/quefrency/rev2/rules.mk b/keyboards/keebio/quefrency/rev2/rules.mk deleted file mode 100644 index 32e7881599..0000000000 --- a/keyboards/keebio/quefrency/rev2/rules.mk +++ /dev/null @@ -1,3 +0,0 @@ -BACKLIGHT_ENABLE = yes -RGBLIGHT_ENABLE = yes -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/quefrency/rev3/info.json b/keyboards/keebio/quefrency/rev3/keyboard.json similarity index 99% rename from keyboards/keebio/quefrency/rev3/info.json rename to keyboards/keebio/quefrency/rev3/keyboard.json index dac80973ae..bd8d86f884 100644 --- a/keyboards/keebio/quefrency/rev3/info.json +++ b/keyboards/keebio/quefrency/rev3/keyboard.json @@ -59,6 +59,17 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "backlight": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_60" }, diff --git a/keyboards/keebio/quefrency/rev3/rules.mk b/keyboards/keebio/quefrency/rev3/rules.mk deleted file mode 100644 index 32e7881599..0000000000 --- a/keyboards/keebio/quefrency/rev3/rules.mk +++ /dev/null @@ -1,3 +0,0 @@ -BACKLIGHT_ENABLE = yes -RGBLIGHT_ENABLE = yes -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/quefrency/rev4/info.json b/keyboards/keebio/quefrency/rev4/keyboard.json similarity index 99% rename from keyboards/keebio/quefrency/rev4/info.json rename to keyboards/keebio/quefrency/rev4/keyboard.json index 4eb4275f7a..936502fdcf 100644 --- a/keyboards/keebio/quefrency/rev4/info.json +++ b/keyboards/keebio/quefrency/rev4/keyboard.json @@ -56,6 +56,16 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_60" }, diff --git a/keyboards/keebio/quefrency/rev4/rules.mk b/keyboards/keebio/quefrency/rev4/rules.mk deleted file mode 100644 index ab97bd78f3..0000000000 --- a/keyboards/keebio/quefrency/rev4/rules.mk +++ /dev/null @@ -1,3 +0,0 @@ -BACKLIGHT_ENABLE = no -RGBLIGHT_ENABLE = yes -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/quefrency/rev5/info.json b/keyboards/keebio/quefrency/rev5/keyboard.json similarity index 99% rename from keyboards/keebio/quefrency/rev5/info.json rename to keyboards/keebio/quefrency/rev5/keyboard.json index 94d77ec8dd..e0fd984772 100644 --- a/keyboards/keebio/quefrency/rev5/info.json +++ b/keyboards/keebio/quefrency/rev5/keyboard.json @@ -56,6 +56,16 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": false, + "mousekey": false, + "extrakey": true, + "rgblight": true, + "encoder": true + }, + "build": { + "lto": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_60" }, diff --git a/keyboards/keebio/quefrency/rev5/rules.mk b/keyboards/keebio/quefrency/rev5/rules.mk deleted file mode 100644 index ab97bd78f3..0000000000 --- a/keyboards/keebio/quefrency/rev5/rules.mk +++ /dev/null @@ -1,3 +0,0 @@ -BACKLIGHT_ENABLE = no -RGBLIGHT_ENABLE = yes -ENCODER_ENABLE = yes diff --git a/keyboards/keebio/quefrency/rules.mk b/keyboards/keebio/quefrency/rules.mk index 33c64f3d65..fb40fc8a56 100644 --- a/keyboards/keebio/quefrency/rules.mk +++ b/keyboards/keebio/quefrency/rules.mk @@ -1,12 +1 @@ -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. - DEFAULT_FOLDER = keebio/quefrency/rev1 -LTO_ENABLE = yes diff --git a/keyboards/keebio/rorschach/rev1/info.json b/keyboards/keebio/rorschach/rev1/keyboard.json similarity index 95% rename from keyboards/keebio/rorschach/rev1/info.json rename to keyboards/keebio/rorschach/rev1/keyboard.json index 22a5de3b93..f7ea8fccc2 100644 --- a/keyboards/keebio/rorschach/rev1/info.json +++ b/keyboards/keebio/rorschach/rev1/keyboard.json @@ -43,6 +43,14 @@ }, "processor": "atmega32u4", "bootloader": "caterina", + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true, + "command": true, + "backlight": true, + "rgblight": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebio/rorschach/rev1/rules.mk b/keyboards/keebio/rorschach/rev1/rules.mk deleted file mode 100644 index bd518d8f27..0000000000 --- a/keyboards/keebio/rorschach/rev1/rules.mk +++ /dev/null @@ -1 +0,0 @@ -BACKLIGHT_ENABLE = yes diff --git a/keyboards/keebio/rorschach/rules.mk b/keyboards/keebio/rorschach/rules.mk index 59170f1516..6cdac68a4e 100644 --- a/keyboards/keebio/rorschach/rules.mk +++ b/keyboards/keebio/rorschach/rules.mk @@ -1,14 +1 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = yes # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. - DEFAULT_FOLDER = keebio/rorschach/rev1 diff --git a/keyboards/keebio/viterbi/rev1/info.json b/keyboards/keebio/viterbi/rev1/keyboard.json similarity index 97% rename from keyboards/keebio/viterbi/rev1/info.json rename to keyboards/keebio/viterbi/rev1/keyboard.json index a003331f25..ebea539248 100644 --- a/keyboards/keebio/viterbi/rev1/info.json +++ b/keyboards/keebio/viterbi/rev1/keyboard.json @@ -19,6 +19,11 @@ "rows": ["D4", "D7", "E6", "B4", "B5"] }, "diode_direction": "COL2ROW", + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_ortho_5x14" }, diff --git a/keyboards/keebio/viterbi/rev1/rules.mk b/keyboards/keebio/viterbi/rev1/rules.mk deleted file mode 100644 index 7b30c0beff..0000000000 --- a/keyboards/keebio/viterbi/rev1/rules.mk +++ /dev/null @@ -1 +0,0 @@ -BACKLIGHT_ENABLE = no diff --git a/keyboards/keebio/viterbi/rev2/info.json b/keyboards/keebio/viterbi/rev2/keyboard.json similarity index 96% rename from keyboards/keebio/viterbi/rev2/info.json rename to keyboards/keebio/viterbi/rev2/keyboard.json index 88ab2cd137..36570e7c7a 100644 --- a/keyboards/keebio/viterbi/rev2/info.json +++ b/keyboards/keebio/viterbi/rev2/keyboard.json @@ -23,6 +23,15 @@ "ws2812": { "pin": "D3" }, + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true, + "backlight": true + }, + "build": { + "lto": true + }, "layout_aliases": { "LAYOUT": "LAYOUT_ortho_5x14" }, diff --git a/keyboards/keebio/viterbi/rev2/rules.mk b/keyboards/keebio/viterbi/rev2/rules.mk deleted file mode 100644 index 674318183b..0000000000 --- a/keyboards/keebio/viterbi/rev2/rules.mk +++ /dev/null @@ -1,3 +0,0 @@ -BACKLIGHT_ENABLE = yes - -LTO_ENABLE = yes \ No newline at end of file diff --git a/keyboards/keebio/viterbi/rules.mk b/keyboards/keebio/viterbi/rules.mk index 5192d5ba72..ecf6a3fa87 100644 --- a/keyboards/keebio/viterbi/rules.mk +++ b/keyboards/keebio/viterbi/rules.mk @@ -1,14 +1 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight. - DEFAULT_FOLDER = keebio/viterbi/rev2 diff --git a/keyboards/keebio/wavelet/info.json b/keyboards/keebio/wavelet/info.json index 3b88fcdd77..7c87bcf476 100644 --- a/keyboards/keebio/wavelet/info.json +++ b/keyboards/keebio/wavelet/info.json @@ -25,6 +25,14 @@ }, "processor": "atmega32u4", "bootloader": "caterina", + "features": { + "bootmagic": false, + "mousekey": true, + "extrakey": true, + "command": true, + "backlight": true, + "rgblight": true + }, "community_layouts": ["ortho_4x12"], "layout_aliases": { "LAYOUT_ortho_4x12": "LAYOUT" diff --git a/keyboards/keebio/wavelet/rules.mk b/keyboards/keebio/wavelet/rules.mk index 74f0e0d566..271780b75e 100644 --- a/keyboards/keebio/wavelet/rules.mk +++ b/keyboards/keebio/wavelet/rules.mk @@ -1,15 +1,2 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = yes # Commands for debug and configuration -NKRO_ENABLE = no # Enable N-Key Rollover -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # Audio output -RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. - # Disable unsupported hardware AUDIO_SUPPORTED = no diff --git a/keyboards/keebwerk/mega/ansi/info.json b/keyboards/keebwerk/mega/ansi/info.json index 27ff1b9e8c..e5a12585df 100755 --- a/keyboards/keebwerk/mega/ansi/info.json +++ b/keyboards/keebwerk/mega/ansi/info.json @@ -15,6 +15,12 @@ "diode_direction": "COL2ROW", "processor": "STM32F303", "bootloader": "stm32-dfu", + "features": { + "bootmagic": true, + "mousekey": true, + "extrakey": true, + "nkro": true + }, "community_layouts": ["65_ansi"], "layouts": { "LAYOUT_65_ansi": { diff --git a/keyboards/keebwerk/mega/ansi/rules.mk b/keyboards/keebwerk/mega/ansi/rules.mk index 82d4a940ed..ba2c38618a 100755 --- a/keyboards/keebwerk/mega/ansi/rules.mk +++ b/keyboards/keebwerk/mega/ansi/rules.mk @@ -3,19 +3,6 @@ # backlight effects. OPT_DEFS += -DNO_SUSPEND_POWER_DOWN -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = yes # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -AUDIO_ENABLE = no # Audio output - CIE1931_CURVE = yes # project specific files diff --git a/keyboards/keebwerk/nano_slider/info.json b/keyboards/keebwerk/nano_slider/info.json index fffbd7701b..cc61c497d7 100644 --- a/keyboards/keebwerk/nano_slider/info.json +++ b/keyboards/keebwerk/nano_slider/info.json @@ -40,6 +40,17 @@ }, "processor": "atmega32u4", "bootloader": "atmel-dfu", + "features": { + "bootmagic": true, + "mousekey": true, + "extrakey": true, + "nkro": true, + "rgblight": true, + "midi": true + }, + "build": { + "lto": true + }, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/keebwerk/nano_slider/rules.mk b/keyboards/keebwerk/nano_slider/rules.mk index d133bb6d6e..cc58820278 100644 --- a/keyboards/keebwerk/nano_slider/rules.mk +++ b/keyboards/keebwerk/nano_slider/rules.mk @@ -1,16 +1 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = yes # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow -MIDI_ENABLE = yes # MIDI support -AUDIO_ENABLE = no # Audio output -LTO_ENABLE = yes - ANALOG_DRIVER_REQUIRED = yes