fern/qmk-firmware
1
0
Fork 0
mirror of https://github.com/firewalkwithm3/qmk_firmware.git synced 2024-11-22 19:40:29 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Improve LED config parsing error messages (#19007)

Browse source
This commit is contained in:
Ryan 2022-11-10 01:02:44 +11:00 committed by GitHub
parent f7df771e70
commit d789b4b7d9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/python/qmk/c_parse.py
View file

@ -216,9 +216,9 @@ def _validate_led_config(matrix, matrix_rows, matrix_indexes, position, position
if len(matrix) != matrix_rows and len(matrix) != (matrix_rows / 2): if len(matrix) != matrix_rows and len(matrix) != (matrix_rows / 2):
raise ValueError("Unable to parse g_led_config matrix data") raise ValueError("Unable to parse g_led_config matrix data")
if len(position) != len(flags): if len(position) != len(flags):
raise ValueError("Unable to parse g_led_config position data") raise ValueError(f"Number of g_led_config physical positions ({len(position)}) does not match number of flags ({len(flags)})")
if len(matrix_indexes) and (max(matrix_indexes) >= len(flags)): if len(matrix_indexes) and (max(matrix_indexes) >= len(flags)):
raise ValueError("OOB within g_led_config matrix data") raise ValueError(f"LED index {max(matrix_indexes)} is OOB in g_led_config - should be < {len(flags)}")
if not all(isinstance(n, int) for n in matrix_indexes): if not all(isinstance(n, int) for n in matrix_indexes):
raise ValueError("matrix indexes are not all ints") raise ValueError("matrix indexes are not all ints")
if (len(position_raw) % 2) != 0: if (len(position_raw) % 2) != 0: